Update qwen3.5-fp8-b300-sglang SGLang image to v0.5.11-cu130#1345
Update qwen3.5-fp8-b300-sglang SGLang image to v0.5.11-cu130#1345Klaud-Cold wants to merge 1 commit into
Conversation
…1154\n\nCo-authored-by: Klaud Cold <Klaud-Cold@users.noreply.github.com>
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
1 similar comment
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| - config-keys: | ||
| - qwen3.5-fp8-b300-sglang | ||
| description: | ||
| - "Update SGLang image from v0.5.10.post1-cu130 to v0.5.11-cu130" | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX |
There was a problem hiding this comment.
🔴 The new perf-changelog entry's pr-link still contains the placeholder XXX (pull/XXX) instead of this PR's actual number 1345. Please replace XXX with 1345 at perf-changelog.yaml:2351 so the changelog link resolves correctly — every preceding entry in this file uses a real PR number.
Extended reasoning...
What the bug is
The new entry appended to perf-changelog.yaml (lines 2347-2351 of the diff) ends with:
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXXXXX is a literal placeholder — clearly left over from a template — rather than the real PR number. The current PR (per the metadata at the top of this review) is #1345, so the link should be https://github.com/SemiAnalysisAI/InferenceX/pull/1345.
How it manifests
After merge, the changelog will contain a URL pointing to /pull/XXX. GitHub does not resolve non-numeric pull request paths, so anyone clicking that link from rendered docs, the raw YAML, or any downstream tooling that consumes perf-changelog.yaml will hit a 404.
Why existing code doesn't prevent it
perf-changelog.yaml is plain data — there is no schema validator in the repo that checks pr-link resolves to a numeric ID. The surrounding entries (lines 2318, 2325, 2332, 2338, 2345) all use real PR numbers (1303, 1304, 1305, 1308, 1310), which is the established convention, but nothing enforces it automatically, so the placeholder slipped through.
Step-by-step proof
- Open this PR's metadata: the PR number is
1345. - Open the diff for
perf-changelog.yamlin this PR — the appended entry's last line ispr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX. - Compare to the entry immediately above it (lines 2338-2345 of the diff context), which ends
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1310— a real, resolvable URL. - Visit
https://github.com/SemiAnalysisAI/InferenceX/pull/XXXafter merge: GitHub will respond with a 404 becauseXXXis not a valid PR ID. - Visit
https://github.com/SemiAnalysisAI/InferenceX/pull/1345: this PR resolves correctly, confirming the intended target.
Impact
Low — this is a documentation/cosmetic issue with no runtime effect. But it is user-visible (anyone consulting the changelog to find the PR that introduced an image bump will hit a dead link) and trivial to fix.
Fix
Replace XXX with 1345 on perf-changelog.yaml:2351:
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1345
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=25763462019 |
1 similar comment
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=25763462019 |
1 participant
Summary
qwen3.5-fp8-b300-sglangimage fromlmsysorg/sglang:v0.5.10.post1-cu130tolmsysorg/sglang:v0.5.11-cu130Ref #1154
Generated with Claude Code